Use POSIX stdout/stderr redirect in configure macro [issue #9990] #9998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew J. Hesford <ajh@sideband.org>
ghost
added
Status: Code Review Needed
behlendorf
approved these changes
Feb 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #9998 +/- ##
========================================
- Coverage 79% 79% -<1%
========================================
Files 385 385
Lines 122382 122382
========================================
- Hits 96904 96829 -75
- Misses 25478 25553 +75
Continue to review full report at Codecov.
|
behlendorf
added
Status: Accepted
rlaager
approved these changes
Feb 14, 2020
gmelikov
approved these changes
Feb 14, 2020
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This PR fixes an issue wherein redirecting stdout and stderr when building kernel modules in configure tests relied on a bashism that does not work as expected when /bin/sh is not bash. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-By: Richard Laager <rlaager@wiktel.com> Signed-off-by: Andrew J. Hesford <ajh@sideband.org> Closes openzfs#9990 Closes openzfs#9998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes issue #9990, wherein redirecting
stdoutandstderrwhen building kernel modules inconfiguretests relied on a bashism that does not work as expected when/bin/shis notbash.Description
This PR implements the correction suggested in issue #9990; simply replacing the
&>combination redirection operator with a POSIX compatible two-stage redirection allows theconfigurescript to function as expected.How Has This Been Tested?
The ZFS module has been built against Linux 4.19.102, 5.4.18 and 5.5.3 on an x86_64 system running Void Linux. Additionally, the patched
configurewas tested by the Void Linux Travis CI system and successfully compiles on x86_64, i686, aarch64, armv7l and armv6l systems with glibc and musl C libraries. (Void PR 19079)Types of changes
Checklist:
Signed-off-by.