Metadata Allocation Classes #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does this need testing? And could you maybe tag PRs that need testing with a label à la "needs testing"? Then I can try to have a look |
So this passes, looks good for merge. |
First rename spare_cbdata_t cb -> spare_cb in print_status_config(), to free up cb. Using the structure removes the explicit parameters namewidth and name_flags from several functions. Also use status_cbdata_t for print_import_config(). This simplifies print_logs(). Remove the parameter 'verbose' for print_logs(). It does not really mean verbose, it selected between the print_status_config and print_import_config() paths. This selection is now done by cb_print_config of spare_cbdata_t. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Håkan Johansson <f96hajo@chalmers.se>
Allocation Classes add the ability to have allocation classes in a pool that are dedicated to serving specific block categories, such as DDT data, metadata, and small file blocks. A pool can opt-in to this feature by adding a 'special' or 'dedup' top-level VDEV. Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Alek Pinchuk <apinchuk@datto.com> Reviewed-by: Håkan Johansson <f96hajo@chalmers.se> Reviewed-by: Andreas Dilger <andreas.dilger@chamcloud.com> Reviewed-by: DHE <git@dehacked.net> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Reviewed-by: Gregor Kopka <gregor@kopka.net> Reviewed-by: Kash Pande <kash@tripleback.net> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Signed-off-by: Don Brady <don.brady@delphix.com>
Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Laager <rlaager@wiktel.com> Signed-off-by: DHE <git@dehacked.net>
|
The actual branch: |
|
The alloc_class test scripts needed change Panic in alloc_class_006 Caused by Mutex Ok, repeated executing of |
|
001 test has causes Is it due to mis-merge or that we have illumos commits. |
|
With the exception of 006, and I had to comment out |
Adding $NAWK and $TRUNCATE. Curious our ksh does not like the space in claim= "" Our zdb -bbcc abort()s. Many create and add require "-f" for the mixing of raidz and mirror check.
|
@don-brady If you have a minute sometime, could you give your thought on the panic in If you also want, you can look at 78fb6dd fixes for test files. I don't think you need to do anything about it, but it could be something to be aware of in future tests files you create :) |
|
I would seem Solaris and ZOL has touched on this issue: openzfs/zfs#7856 But it is not fixed with ZOLs openzfs/zfs@733b572 Repeatedly running is enough to trigger here, about ~20 times. |
Added vdev_resilver_needed() check to verify VDEVs are fully synced, so that after split the new pool will not be corrupted. Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: loli10K <ezomori.nozomu@gmail.com> Signed-off-by: Roman Strashkin <roman.strashkin@nexenta.com>
Added missing remove of detachable VDEV from txg's DTL list to avoid use-after-free for the splitted VDEV Signed-off-by: Roman Strashkin <roman.strashkin@nexenta.com>
|
After applying ZOL openzfs/zfs@cec8583 from openzfs/zfs#7856 The panics go away: We will take this commit, with thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the OSX version of: openzfs/zfs#5182
It was easier to include the "status_cbdata_t" changes to prints as well, and we could consider ZOL 8720e9e7482fa2d
Add -c to zpool iostat & status to run command.