Refactor: Fix CLI issues #12
Conversation
There was a problem hiding this comment.
Thank you for this contribution.
Why did you renamed fcc2zim to fcctozim? I think (at least from the scrapers I've experienced with) the former (fcc2zim) is more in our habits (conventions?) and at least I do not see any issue with this old name.
FYI, from this point I will take the ownership of the issue and work on it, there is still quite a significant work to do, it seems pretty hard to do for someone not in our core team and we would like to add freecodecamp to the zimfarm "asap". I hope you will understand and not be offended by this.
|
Superseeded by #14 |
|
@benoit74 Not offended at all. I renamed it to fcctozim to match up to the lib name, but feel free to keep it fcc2zim, it should have no effect on the outcome. |
|
Cool. Lib name will be fcc2zim to match other scrapers, so I will keep this name in the code as well 😄 |
Fixes some of the feedback on #11 with regards to drying up the CLI arguments. Also fixes #13 by updating zimscraperlib to 3.1.1 and adding a long_description flag.