Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace « mul » ZIM « language » metadata in the multiple language ZiM #174

Closed
kelson42 opened this issue Feb 26, 2023 · 6 comments · Fixed by #178
Closed

Replace « mul » ZIM « language » metadata in the multiple language ZiM #174

kelson42 opened this issue Feb 26, 2023 · 6 comments · Fixed by #178
Assignees
@rgaudin
Labels
enhancement good first issue
Milestone
2.1.0

Comments

@kelson42
Copy link
Contributor

With kiwix/libkiwix#872 (comment) we have decided to not use anymore this « special » ZIM language code. Instead we want to striclty respect the ZIM specification and put the list of languages in a comma separated string.
@kelson42 kelson42 modified the milestones: 3.0.0, 2.1.0 Feb 26, 2023
@kelson42 kelson42 changed the title Replace « mul » ZIM labguage metadata in the multiple language ZiM Replace « mul » ZIM « language » metadata in the multiple language ZiM Feb 26, 2023
@rgaudin
Copy link
Member

rgaudin commented Feb 26, 2023

Although the spec doesn't mention anything, it's likely that readers will only display a couple languages at first sight with the rest in an extended view.

I would thus suggest to list the languages ordered by "importance" which we can set to number of entries for the moment.

@kelson42
Copy link
Contributor Author

kelson42 commented Feb 26, 2023 •
edited

@rgaudin What would be the definition of "important"?

@rgaudin
Copy link
Member

rgaudin commented Feb 26, 2023

I wrote in my comment that we can consider nb of books for now

@kelson42
Copy link
Contributor Author

kelson42 commented Feb 26, 2023 •
edited

@rgaudin sorry! LGTM, we can update the spec.

@rgaudin rgaudin self-assigned this Mar 2, 2023
@kelson42
Copy link
Contributor Author

kelson42 commented Mar 8, 2023

@rgaudin Can we fix this quickly?

rgaudin added a commit that referenced this issue Mar 8, 2023
@rgaudin
Fixed #174: proper multi language metadata and filenames
b0dfb33
@rgaudin rgaudin mentioned this issue Mar 8, 2023
Merged
@kelson42
Copy link
Contributor Author

kelson42 commented Mar 8, 2023

Specification updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgaudin rgaudin

Labels
enhancement good first issue
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Proper multi language metadata and filenames openzim/gutenberg
2 participants
@rgaudin @kelson42