Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart choice of M/Illustration_[heigt]x[width] #541

Open
kelson42 opened this issue Apr 21, 2021 · 2 comments
Open

Smart choice of M/Illustration_[heigt]x[width] #541

kelson42 opened this issue Apr 21, 2021 · 2 comments
Labels
enhancement
Milestone
10.0.0

Comments

@kelson42
Copy link
Contributor

This ticket is a follow up of #527

The API should return the given resolution, but it would be good, given a height and a width in pixels, that the libzim just deliver the best approximation.
@kelson42 kelson42 added this to the 7.1.0 milestone Jul 8, 2021
@kelson42
Copy link
Contributor Author

kelson42 commented Jul 8, 2021

This is important to allow readers to benefit of multiple illustrations. Without this feature, readers will have to implement the same kind of logic at there level… and we don’t want that.

@mgautierfr mgautierfr mentioned this issue Nov 8, 2021
Merged
@kelson42
Copy link
Contributor Author

kelson42 commented Jan 2, 2022

I guess screen pixel depth shoukd be an argument as well.

@kelson42 kelson42 modified the milestones: 8.2.0, 8.3.0 Mar 11, 2023
@kelson42 kelson42 modified the milestones: 8.3.0, 9.0.0 Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
1 participant
@kelson42