[Compression] Correctly try to reallocate only when no output data. #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 82.80% 82.78% -0.02%
==========================================
Files 91 91
Lines 3820 3822 +2
Branches 1702 1703 +1
==========================================
+ Hits 3163 3164 +1
- Misses 656 657 +1
Partials 1 1
Continue to review full report at Codecov.
|
veloman-yunkan
approved these changes
Jul 31, 2021
kelson42
force-pushed
the
fix_compression_realloc
branch
from
33d475d
to
d915b18
Compare
|
@veloman-yunkan thx for review, will rebase and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of bug introduced with commit a7201ce.
Fix #578