For xapian to check 10 documents when asking for empty mset. #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing xapian to check 1 documents is not enough and it may still leads to wrong results. This is difficult to know which is the good number to put here, between a small number to avoid too many checks and a big number to force a accurate result. 10 seems to work for now, at least for small results set as used in tests.
Codecov Report
@@ Coverage Diff @@
## master #625 +/- ##
=======================================
Coverage 84.55% 84.55%
=======================================
Files 97 97
Lines 4183 4183
Branches 1883 1858 -25
=======================================
Hits 3537 3537
Misses 645 645
Partials 1 1
Continue to review full report at Codecov.
|
maneeshpm
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Selecting a good number is indeed difficult. But I trust your testing here and we can expedite the need for a unit test.
But yes, since most of our implementation in libkiwix deals with getting results in the range 10(for suggestions) to 25(for search), checking at least 10 results seems reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing xapian to check 1 documents is not enough and it may still leads to wrong results.
This is difficult to know which is the good number to put here, between a small number to avoid too many checks and a big number to force a accurate result.
10 seems to work for now, at least for small results set as used in tests.
This fix the unit test bug in python-libzim https://github.com/openzim/python-libzim/runs/3672830814
I ask for a favor here and do not add a specific unit test in libzim.
It would need to add a new content in openzim/zim_testing_suite and the change is pretty well contained, I don't see how it could break things.