Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependences version #656

Merged
merged 6 commits into from
Dec 31, 2021
Merged

Dependences version #656

merged 6 commits into from
Dec 31, 2021

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Dec 29, 2021

Fixes #452

Global idea is to build something similar in libkiwix and then call zim::versions() and/or kiwix::versions() in end-user tools like kiwix-desktop, kiwix-tools, etc.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #656 (e95fb60) into master (c5caa51) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

❗ Current head e95fb60 differs from pull request most recent head 9bca6c5. Consider uploading reports for the commit 9bca6c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   85.05%   84.84%   -0.21%     
==========================================
  Files          97       98       +1     
  Lines        4221     4231      +10     
  Branches     1873     1880       +7     
==========================================
  Hits         3590     3590              
- Misses        630      640      +10     
  Partials        1        1              
Impacted Files Coverage Δ
src/version.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5caa51...9bca6c5. Read the comment docs.

src/version.cpp Outdated Show resolved Hide resolved
@kelson42
Copy link
Contributor Author

@veloman-yunkan I have finally implemented something I had in mind and hopefully fit to your first comment.

@kelson42 kelson42 force-pushed the dependences_version branch 2 times, most recently from 28d9b07 to 4d5eee4 Compare December 30, 2021 18:39
include/zim/meson.build Show resolved Hide resolved
include/zim/zim.h Outdated Show resolved Hide resolved
include/zim/zim.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last improvement

src/version.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@veloman-yunkan veloman-yunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it were not for CI failure I would have approved this PR. But obviously it can't be merged in this shape.

@kelson42
Copy link
Contributor Author

If it were not for CI failure I would have approved this PR. But obviously it can't be merged in this shape.

yes, will have a look but not clear what happens on Windows.

@kelson42
Copy link
Contributor Author

@veloman-yunkan I think we are good now, right?

@kelson42 kelson42 merged commit f5921f9 into master Dec 31, 2021
@kelson42 kelson42 deleted the dependences_version branch December 31, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gather informations about dependence libraries version
2 participants