-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependences version #656
Dependences version #656
Conversation
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 85.05% 84.84% -0.21%
==========================================
Files 97 98 +1
Lines 4221 4231 +10
Branches 1873 1880 +7
==========================================
Hits 3590 3590
- Misses 630 640 +10
Partials 1 1
Continue to review full report at Codecov.
|
faa3201
to
97d88e2
Compare
@veloman-yunkan I have finally implemented something I had in mind and hopefully fit to your first comment. |
28d9b07
to
4d5eee4
Compare
4d5eee4
to
d34d1cc
Compare
d34d1cc
to
ea2cde3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were not for CI failure I would have approved this PR. But obviously it can't be merged in this shape.
yes, will have a look but not clear what happens on Windows. |
e95fb60
to
33cd443
Compare
@veloman-yunkan I think we are good now, right? |
33cd443
to
3580bf5
Compare
3580bf5
to
9bca6c5
Compare
Fixes #452
Global idea is to build something similar in libkiwix and then call zim::versions() and/or kiwix::versions() in end-user tools like kiwix-desktop, kiwix-tools, etc.