Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more informative error message #668

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

veloman-yunkan
Copy link
Collaborator

The previous PR (#667) was merged before I could improve it. Hence another small PR.

@kelson42
Copy link
Contributor

@veloman-yunkan Sorry for merging to quickly. Good in the principle, but it seems that too many CI are faling (beside the usual macOS ones)!

@veloman-yunkan veloman-yunkan force-pushed the even_more_informative_file_opening_error branch from 6497a2f to 3776b66 Compare February 13, 2022 14:31
@veloman-yunkan
Copy link
Collaborator Author

@veloman-yunkan Sorry for merging to quickly. Good in the principle, but it seems that too many CI are faling (beside the usual macOS ones)!

Indeed. I lost one change (an #include) when moving the extra fix to a new PR. Now the CI should fail in an expected way.

@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #668 (3776b66) into master (71d25f9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   84.77%   84.78%           
=======================================
  Files          98       98           
  Lines        4224     4225    +1     
  Branches     1889     1890    +1     
=======================================
+ Hits         3581     3582    +1     
- Misses        641      642    +1     
+ Partials        2        1    -1     
Impacted Files Coverage Δ
src/fs_unix.cpp 94.23% <100.00%> (+0.11%) ⬆️
src/version.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d25f9...3776b66. Read the comment docs.

@kelson42 kelson42 merged commit a12d14a into master Feb 13, 2022
@kelson42 kelson42 deleted the even_more_informative_file_opening_error branch February 13, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants