New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add __declspec(dllexport) to class #783
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 56.07% 56.07%
=======================================
Files 98 98
Lines 4394 4394
Branches 1910 1910
=======================================
Hits 2464 2464
Misses 672 672
Partials 1258 1258
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
469b1f6
to
d44b184
Compare
@mgautierfr can you approve this to run the checks |
Small comment about the naming: I would prefer DECLSPEC in place of ZIM_LIB, only my opinion. |
d44b184
to
bcc2a96
Compare
done |
a44d856
to
4fc32bc
Compare
bafd7ba
to
9775e58
Compare
9775e58
to
9e65f2f
Compare
9e65f2f
to
936d3a5
Compare
@veloman-yunkan Are we good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last small change and we can merge
fix build dynamic library issue on Windows
6143770
to
841ffdf
Compare
fixes #780
related to #741