Add wrapper on creator.addAlias.
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaudin
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks!
@mgautierfr you says this needs openzim/libzim#833 but that libzim branch uses addAlias and not addClone anymore.
I guess you want the pylibzim wrapper to switch to add_alias as well.
|
Adapted to add_alias. |
rgaudin
approved these changes
Nov 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 93.52% 93.44% -0.09%
==========================================
Files 1 1
Lines 510 519 +9
==========================================
+ Hits 477 485 +8
- Misses 33 34 +1 ☔ View full report in Codecov by Sentry. |
mgautierfr
changed the title
creator.addClone.creator.addAlias.
|
Should be ok to merge now ? |
|
This PR is blocked by openzim/libzim#837 (written in description) |
|
I merged with the nightly (that's usual for this repo) but we need a release of libzim to release pylibzim to release scraperlib… to integrate in warc2zim |
This was referenced Dec 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need openzim/libzim#833
Blocked by openzim/libzim#837