Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Skip if necessary ZIM file isn't present #76

Merged
merged 1 commit into from Jul 27, 2020

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 25, 2020

The large ZIM files used for tests are not included in the release
tarball because of their size. But we still want the tests to pass
in that case, so skip if the file is missing.

Fixes #68.

This is an alternative to #69.

The large ZIM files used for tests are not included in the release
tarball because of their size. But we still want the tests to pass
in that case, so skip if the file is missing.

Fixes #68.
@codecov
Copy link

codecov bot commented Jul 25, 2020

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           99        99           
=========================================
  Hits            99        99           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36cc20...ff560ea. Read the comment docs.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Will replace the large ZIM files with smaller ones in the future so that we can embed them

@rgaudin rgaudin merged commit 48fafbe into master Jul 27, 2020
@rgaudin rgaudin deleted the legoktm-skip-tests branch July 27, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/*.zim files not included in release tarball
2 participants