-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues in MDN
zimit2 ZIM: links are opening online instead of staying in the ZIM
#178
Comments
Hmm, this "shouldn't" be possible since a sandbox was added to the Kiwix Serve iframe, unless it's been removed or you're opening the page directly outside of an iframe... Maybe you could make a small, 5-6 page ZIM including home page for testing? |
You are right, I pushed the file to dev.library.kiwix.org (here: https://dev.library.kiwix.org/viewer#developer.mozilla.org_en_all_2024-02) and the bug is not present there. The bug is only present when running locally. Locally I'm using Docker image of kiwix-tools 3.6.0. Is there any parameter which needs to be set to activate the sandbox? |
The sandbox is in the viewer iframe on Kiwix Serve, I believe, though it's also possible to set it via CSP headers server side. |
Another issue with this ZIM: a number of articles (which I've verified to be in the ZIM) get redirected nearly instantly to a custom Mozilla 404 page. If you're quick, you can just see a flash of the original content before it gets redirected. Here's an example:
NB I can see the content of such pages has been cached, and is all there and correct. The DevTools Cache API page even shows a graphical view of the loaded page (see screenshot). The redirect definitely happens after DOMContentReady as a result of a dynamic Fetch request (possibly one of the many POST requests). In the zimit1 version there are several Header lookups, and also some attempt to do fuzzy matching in the Service Worker after the content has loaded. |
The fix is kiwix/libkiwix#1036 (confirm with @benoit74) https://dev.library.org is nightly (and so, contains the fix), docker is release and doesn't have the fix. |
The redirect issue I mentioned above is occurring on dev.library.org, therefore it must be something else (I thought it was related to the problem of determining the final location of a ZIM URL, hence related to this issue). I'll make it into a separate issue, then. |
I made ZIM on my local machine with latest zimit2 image (based on warc2zim 2.0.0-dev3) based on WARC files at https://tmp.kiwix.org/ci/test-warc/developer.mozilla.org_en_2024-02-04/
warc2zim command used to test locally:
A ZIM is produced successfully, but there is still a significant issue: most (all?) links on the home page seems to point to the ZIM content (they are relative links) but when clicked the live online website is opened. Probably some Javascript is doing some nasty stuff. This has been observed in kiwix-serve, I did not tested other readers, probably doesn't make a difference.
The text was updated successfully, but these errors were encountered: