Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zimit2: HTML demos on developer.mozilla.org (MDN) pages are not working #293

Open
benoit74 opened this issue May 31, 2024 · 6 comments · May be fixed by #334
Open

Zimit2: HTML demos on developer.mozilla.org (MDN) pages are not working #293

benoit74 opened this issue May 31, 2024 · 6 comments · May be fixed by #334
Assignees
Labels
bug Something isn't working upstream
Milestone

Comments

@benoit74
Copy link
Collaborator

image

See https://dev.library.kiwix.org/content/developer.mozilla.org_en_all_2024-05/interactive-examples.mdn.mozilla.net/pages/tabbed/section.html for isolated test case.

This worked well in zimit1 and is working well in replayweb.page

URL and other arguments passed by wombat to our URL rewriting function are unusual:

urlRewriten:
	- current_url: http://135.181.181.97:8888/content/devmdn-bcd_2024-05/interactive-examples.mdn.mozilla.net/pages/tabbed/section.html
	- orig_host: interactive-examples.mdn.mozilla.net
	- orig_scheme: https
	- orig_url: https://interactive-examples.mdn.mozilla.net/pages/tabbed/section.html
	- prefix: http://135.181.181.97:8888/content/devmdn-bcd_2024-05/
	- url: http://mp_/blob:57e8dbed-cfaf-4e0b-a259-a23170aaf29c/https://interactive-examples.mdn.mozilla.net/pages/tabbed/section.html
	- useRel: false
	- mod: if_
	- doc: undefined
	- finalUrl: http://135.181.181.97:8888/content/devmdn-bcd_2024-05/mp_/blob%3A57e8dbed-cfaf-4e0b-a259-a23170aaf29c/https%3A//interactive-examples.mdn.mozilla.net/pages/tabbed/section.html

mod = if_ and url with mp_ seems pretty special

@benoit74 benoit74 added the bug Something isn't working label May 31, 2024
@benoit74 benoit74 added this to the 2.0.0 milestone May 31, 2024
@benoit74 benoit74 self-assigned this May 31, 2024
@benoit74
Copy link
Collaborator Author

Postponing to 2.1, not an easy feat to be solved.

@Jaifroid
Copy link

Jaifroid commented Jun 5, 2024

It looks like this might be related to the encoding of the querystring? In PWA I see this. Note that the app tried to call the contents with an encoded querystring, as we had decided, but the contents are actually stored in the ZIM with a plain question mark and other separators unencoded. EDIT: This is incorrect, please ignore.

@Jaifroid
Copy link

Jaifroid commented Jun 5, 2024

Apologies, that was a red herring. It's just that that part of the console dev tools shows the requests in this way (encoded). It's the same for video that DOES work, so it's not that.

These code demo panels seem to work fine when it's a case of showing how JavaScript functions work, but they don't work when the content is HTML. Which is a bit strange.

@benoit74
Copy link
Collaborator Author

To be investigated in 2.1 to at least better understand the problem

@benoit74
Copy link
Collaborator Author

Explanation and dirty hack found and working well, ticket opened in webrecorder/wombat to find the proper solution to fix this, there is definitely lots of hope ^^

@benoit74 benoit74 changed the title Zimit2: HTML demos on MDN pages are not working Zimit2: HTML demos on developer.mozilla.org (MDN) pages are not working Jun 21, 2024
@benoit74
Copy link
Collaborator Author

Still blocked by webrecorder/wombat#158

@benoit74 benoit74 modified the milestones: 2.1.0, 2.2.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants