Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Link DockerHub repositories with GitHub #89

Closed
gena01 opened this issue Mar 16, 2016 · 6 comments
Closed

Link DockerHub repositories with GitHub #89

gena01 opened this issue Mar 16, 2016 · 6 comments

Comments

@gena01
Copy link
Contributor

gena01 commented Mar 16, 2016

There's a couple of benefits for doing this:

  1. README.md file(s) are pulled into the description.
  2. Dockerfile used by the automation build is imported and updated in Docker Hub (Dockerfile tab)
  3. There's a new link added from DockerHub to Github in order to find the github repo (source files)
  4. Docker Hub can do the builds automatically based on tags/branches/regexp/etc.. and publish the images.
@codefromthecrypt
Copy link

Here's the most recent discussion on the topic #86 Mind having a look and sanity checking the idea with that in mind?

@abesto
Copy link
Contributor

abesto commented Mar 24, 2016

(And this is another repo I totally failed to "Watch". Fixed that now.)

Yeah, in theory I agree; in practice #86 describes pretty well why there's been no move yet. If this is mostly about documenting the state of things, that's also great input.

Another thing that's been discussed is exploding this "monorepo" into image-specific repositories, which may reduce the scope of this change by constraining each work item to a single image. The thing to keep in mind there is synchronization between the images - do we always rebuild all of them? Which versions are compatible with which other versions?

@codefromthecrypt
Copy link

one thing that came up recently is that quay remembered a bad download (cached). Without a busting strategy, only option is to bump the version. docker itself has a no-cache flag, which would obviate this. We could also somehow build something into our dockerfile to read a variable from Quay that busts the cache.

here's a related issue: moby/moby#1326

I'm not sure if dockerhub is better or worse in this regard. Bad downloads are rare, but it did distract for a while.

@codefromthecrypt
Copy link

cc @dmitry-prokopchenkov who got bit by this on a stale zipkin-dependencies image

@anuraaga
Copy link
Contributor

All the repos are linked now so think this issue is resolved (docker hub builds of release builds tracked in other issues)

@codefromthecrypt
Copy link

codefromthecrypt commented Aug 31, 2019 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants