Upload files

[jpiechowka]

No description provided.

[eirslett]

Are you sure this is correct?

[jpiechowka]

@eirslett
This is what I used:
Zipkin-js-example
Zipkin-instrumentation-cujojs-rest

It works for me, the only issue with this right now is this, so I used dirty workaround of adding timeout:
Zipkin-js/issues/33

[eirslett]

I was unsure about the part "const nameOfRemoteService = 'cujojs-client';". I would suppose cujojs-client is the name of the local service, not the remote one?

[jpiechowka]

@eirslett Oh, yes it is name of the local service - the client. There is a screenshot in the repo if you want to see how it looks in Zipkin.

[eirslett]

Yes, that's why I thought maybe a name like "const nameOfClient = 'cujojs-client';" would be more descriptive?

[codefromthecrypt]

+1

On 21 Aug 2016 1:36 am, "Eirik Sletteberg" notifications@github.com wrote:

Yes, that's why I thought maybe a name like "const nameOfClient =
'cujojs-client';" would be more descriptive?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61zI1N7qKOs3bF_jCqx7ILnYeCVubks5qhzs5gaJpZM4JpD7x
.

[jpiechowka]

@eirslett I have changed nameOfRemoteService to nameOfClient.