Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tries to hone OSGi imports according to use #1252

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Tries to hone OSGi imports according to use #1252

merged 1 commit into from
Sep 11, 2020

Conversation

codefromthecrypt
Copy link
Member

It is my understanding that unless we shade something, we have to add
internal import for the few utilities we use.

Fixes #1248

Tries to hone OSGi imports according to use
aba62b4 
It is my understanding that unless we shade something, we have to add
internal import for the few utilities we use.

Fixes #1248
This was referenced Sep 11, 2020
Merged
Closed
reta
reta approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, brave exports brave.internal with mandatory braveinternal attribute, the imports look correct.

@reta
Copy link
Contributor

reta commented Sep 11, 2020

Just checked the recent build, looks perfect

Import-Package: brave.baggage;version="[5.12,6)",brave.internal;braveint
 ernal=true;version="[5.12,6)",brave.propagation;version="[5.12,6)",org.
 slf4j;version="[1.7,2)"

@codefromthecrypt
Copy link
Member Author

Thanks also to @helgoboss for identifying and closely looking at this. Appreciate the second, well third eyes @reta!

@codefromthecrypt codefromthecrypt merged commit 06b71b0 into master Sep 11, 2020
@codefromthecrypt codefromthecrypt deleted the osgi-try branch September 11, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSGi package import missing in context-slf4j
2 participants
@codefromthecrypt @reta