Ensures current span is always closed prior to finishing #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
11 tasks
|
note I tried to pay for this change by removing duplicate logic in tests |
codefromthecrypt
commented
May 7, 2017
| @@ -12,35 +13,25 @@ public HttpClientHandler(HttpAdapter<Req, Resp> adapter, HttpClientParser parser | |||
| this.parser = parser; | |||
| } | |||
|
|
|||
| public Req handleSend(Req request, Span span) { | |||
| if (span.isNoop()) return request; | |||
| public void handleSend(Req request, Span span) { | |||
There was a problem hiding this comment.
these return values weren't used, or when used encouraged people to use a span in scope.
codefromthecrypt
force-pushed
the
close-scope
branch
2 times, most recently
from
462461f
to
f382cec
Compare
This changes logic in http handlers such that a span is always closed prior to being finished. This has two advantages: one is that we can test that instrumentation do not leak span contexts. Another is that log context synchronization will not add trace IDs of a closed span.
codefromthecrypt
force-pushed
the
close-scope
branch
from
f382cec
to
63f83ff
Compare
|
boatload of test backfills next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes logic in http handlers such that a span is always closed
prior to being finished. This has two advantages: one is that we can
test that instrumentation do not leak span contexts. Another is that
log context synchronization will not add trace IDs of a closed span.