Brave 3.0.0-beta-1 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client abstraction is actually a http client abstraction. Make this explicit with name change. Also includes updating all references in pom files.
This is temporary. Should be fixed before merging.
The mysql implementation does obviously not need brave-http-client dependency.
Upgrade compile source and target to Java 1.8 for all modules. As a result of upgrading we also needed to upgrade all modules depending on Spring to version 4.1.6.RELEASE from 3.2.2.RELEASE.
Travis build failed since we updated to Java 8. Fix Travis build config.
Remove unneeded dependency, probably result of copy/paste of pom.xml
Move from brave-interfaces module to brave-http-client module. These are specific to http client integration so move them to appropriate sub module.
Dependency on brave-http-client is enough. No need to specifically depend on brave-interfaces.
Revert previous rename to not brake backwards compatibility. This module will become deprecated at a later stage.
Implement logic on how to deal with incoming request and outgoing response. Currently this logic is duplicated across different implementations. With these changes in place only an adapter needs to get implemented which hides the specifics of the platform. Should safe on code duplication.
Use new functionality introduced in Java 8. Add new getter method and deprecate old one.
SpanId becomes implementation instead of interface.
Instead of individual long properties we now re-use a single SpanId property.
These new implementations should deprecate the implementations present in brave-client submodule which are too complicated and http specific.
Support providing custom annotations in adapters which can be added to span.
Will move the flume zipkin sinks to separate repos. This is a preparation step, remove them from multi module build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main topics:
flume-zipkin-collector-sinkandflume-zipkin-metrics-sinkfrom multi module build. This is a preparation step for moving those into their own repos which will be done after merging to master. They have nothing directly to do with brave as they only rely on the zipkin thrift structures. They will have different release cycle, so separate them at a later stage.Other preparation work that is in this release but not yet integrated in existing client/server support (integration will be for next beta release):
ServerRequestInterceptorandServerResponseInterceptorimplementations. This should remove code duplication. Also mentioned in Brave 3.0.0 #59ClientRequestInterceptorandClientResponseInterceptorwhich are usable for non http implementations. These will deprecate currentbrave-clientmodule.