Bring zipkin-finagle up to date #149
Conversation
reta
force-pushed
the
issue-142
branch
8 times, most recently
from
828a8bc
to
3de26d4
Compare
|
@codefromthecrypt would really appreciate if you could find a time to look at it: this is first step to bring the project back to shape, the other things (Docker, Github Actions, SPDX licenses, ... ) to follow shortly, thanks! |
reta
force-pushed
the
issue-142
branch
2 times, most recently
from
4fba2ec
to
0ac1a36
Compare
Signed-off-by: Andriy Redko <drreta@gmail.com>
core/pom.xml
Outdated
| @@ -19,12 +19,12 @@ | |||
|
|
|||
| <parent> | |||
| <groupId>io.zipkin.finagle2</groupId> | |||
| <artifactId>zipkin-finagle-parent_2.12</artifactId> | |||
| <version>22.4.0</version> | |||
| <artifactId>zipkin-finagle-parent_2.13</artifactId> | |||
There was a problem hiding this comment.
hmm I thought in our build we did some tricks to dual publish to 12 and 13 via replacement?
It is both, you are very right, I will take care of that, thanks! |
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
|
another thing I think we should figure out how to turn off scala-steward and close all the unaddressed spam PRs.. |
Sure, I think once we merge this one, many will be auto closed |
Co-authored-by: Adrian Cole <64215+codefromthecrypt@users.noreply.github.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
|
Thanks @reta! |
Bring zipkin-finagle up to date