Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include the http.status_code when 2xx in server #162

Closed
jcchavezs opened this issue Mar 31, 2020 · 2 comments
Closed

Don't include the http.status_code when 2xx in server #162

jcchavezs opened this issue Mar 31, 2020 · 2 comments

Comments

@jcchavezs
Copy link
Contributor

According to https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpResponseParser.java#L67, by default http.status_code tag should only be present if the tag is not 2xx. It makes sense to replicate this condition here in server instrumentation given that client does it already.
@dengliming
Copy link
Contributor

+1

@dengliming dengliming mentioned this issue Aug 10, 2020
Merged
@jcchavezs
Copy link
Contributor Author

Thanks @dengliming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcchavezs @dengliming