We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
According to https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpResponseParser.java#L67, by default http.status_code tag should only be present if the tag is not 2xx. It makes sense to replicate this condition here in server instrumentation given that client does it already.
http.status_code
2xx
The text was updated successfully, but these errors were encountered:
+1
Sorry, something went wrong.
Thanks @dengliming
No branches or pull requests
According to https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpResponseParser.java#L67, by default
http.status_code
tag should only be present if the tag is not2xx
. It makes sense to replicate this condition here in server instrumentation given that client does it already.The text was updated successfully, but these errors were encountered: