Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reporter/kafka): fixes the SpanSerializer option usage. #156

Merged
merged 1 commit into from
Nov 4, 2019
Merged

fix(reporter/kafka): fixes the SpanSerializer option usage. #156

merged 1 commit into from
Nov 4, 2019

Conversation

jcchavezs
Copy link
Contributor

This PR fixes the usage of the spanSerializer in kafka reporter as it was ignored.

Ping @basvanbeek @jeqo

@coveralls
Copy link

coveralls commented Oct 22, 2019 •
edited

Coverage Status

Coverage decreased (-12.6%) to 62.873% when pulling 34d8c20 on fixes_kafka_serializer into c29478e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.3%) to 66.142% when pulling 34d8c20 on fixes_kafka_serializer into c29478e on master.

@jcchavezs jcchavezs merged commit bafd576 into master Nov 4, 2019
@jcchavezs jcchavezs deleted the fixes_kafka_serializer branch November 4, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcchavezs @coveralls