Add GCP Cloud PubSub reporter #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum
# Conflicts: # go.mod # go.sum
jcchavezs
reviewed
Nov 27, 2019
jcchavezs
reviewed
Nov 27, 2019
|
I will use stubReporter. Working on in now. |
golangcibot
reviewed
Dec 7, 2019
|
I introduce stubReporter and stubClient. |
jcchavezs
reviewed
May 7, 2020
| @@ -1,25 +1,31 @@ | |||
| module github.com/openzipkin/zipkin-go | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
I see many dependencies being added, did you try go mod tidy?
jcchavezs
reviewed
May 7, 2020
| var resultMsg = make(chan reporterResult) | ||
|
|
||
| // Reporter implements Reporter by publishing spans to a GCP gcppubsub. | ||
| type Reporter struct { |
There was a problem hiding this comment.
I am curious about this being exported. Can't this be private?
jcchavezs
reviewed
May 7, 2020
|
|
||
| const defaultPubSubTopic = "defaultTopic" | ||
|
|
||
| var resultMsg = make(chan reporterResult) |
There was a problem hiding this comment.
Just out of curiosity, why this is not part of the struct that entirely uses it? Also, could we rename it into resultMsgC otherwise it is the easiest to understand what happens in line 104.
|
Any feedback @basvanbeek ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why