Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): makes examples its own module to avoid unnecessary dependencies in the main go.mod. #191

Merged
merged 1 commit into from
Mar 21, 2021
Merged

chore(examples): makes examples its own module to avoid unnecessary dependencies in the main go.mod. #191

merged 1 commit into from
Mar 21, 2021

Conversation

jcchavezs
Copy link
Contributor

This PR turns the HTTP server example into its own module to decrease dependency list in the main module.

Ping @anuraaga @basvanbeek

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 73.267% when pulling 3921e5e on make_example_its_own_module into 0b3ebdb on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 73.267% when pulling 3921e5e on make_example_its_own_module into 0b3ebdb on master.

@jcchavezs jcchavezs merged commit 815bc64 into master Mar 21, 2021
@jcchavezs jcchavezs deleted the make_example_its_own_module branch March 21, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcchavezs @coveralls @anuraaga