[#68] Exposes alwaysSample and NeverSample to easier usage. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jcchavezs
force-pushed
the
exposes_binary_samplers
branch
from
eec0de0
to
7d6e269
Compare
jcchavezs
force-pushed
the
exposes_binary_samplers
branch
from
7d6e269
to
b9504cf
Compare
basvanbeek
requested changes
Jul 16, 2018
sample.go
Outdated
| @@ -12,14 +12,17 @@ import ( | |||
| // traceID. | |||
| type Sampler func(id uint64) bool | |||
|
|
|||
| func neverSample(_ uint64) bool { return false } | |||
| // NeverSample samples no traces | |||
There was a problem hiding this comment.
NeverSample will always return false. If used by a service it will not allow the service to start traces but will still allow the service to participate in traces started upstream.
sample.go
Outdated
|
|
||
| func alwaysSample(_ uint64) bool { return true } | ||
| // AlwaysSample samples all traces, it is appropriate for easy prototyping but not | ||
| // meant to be used in production. |
There was a problem hiding this comment.
AlwaysSample will always return true. If used by a service it will always start traces if no upstream trace has been propagated. If an incoming upstream trace is not sampled the service will adhere to this and only propagate the context.
|
Thanks @jcchavezs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Ping @basvanbeek