Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#80): removes http.response.size when response body is empty. #82

Merged
merged 1 commit into from
Sep 27, 2018
Merged

fix(#80): removes http.response.size when response body is empty. #82

merged 1 commit into from
Sep 27, 2018

Conversation

jcchavezs
Copy link
Contributor

Related to #80 and #81

Ping @basvanbeek

@ghost ghost assigned jcchavezs Sep 27, 2018
@ghost ghost added the review label Sep 27, 2018
basvanbeek
basvanbeek approved these changes Sep 27, 2018
View reviewed changes
Copy link
Member

@basvanbeek basvanbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.444% when pulling ebf7ad5 on 80_removes_response_size_on_empty into 1cbef8b on master.

@jcchavezs jcchavezs merged commit 70244c9 into master Sep 27, 2018
@ghost ghost removed the review label Sep 27, 2018
@jcchavezs jcchavezs deleted the 80_removes_response_size_on_empty branch September 27, 2018 12:00
@jcchavezs jcchavezs mentioned this pull request Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvanbeek basvanbeek basvanbeek approved these changes

Assignees

@jcchavezs jcchavezs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcchavezs @coveralls @basvanbeek