Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow httpServer instrumentation host to be overridden #236

Closed
rcoedo opened this issue Jul 10, 2018 · 1 comment
Closed

Allow httpServer instrumentation host to be overridden #236

rcoedo opened this issue Jul 10, 2018 · 1 comment

Comments

@rcoedo
Copy link
Contributor

rcoedo commented Jul 10, 2018

Currently the httpServer instrumentation implementation is querying the OS to find the host's ip address on every request. This can lead to a performance problem when the server is under heavy load.

performance

Allowing the host to be overridden is a simple fix for this problem and it wouldn't break the API.
rcoedo pushed a commit to rcoedo/zipkin-js that referenced this issue Jul 10, 2018
Allow host to be overridden in httpServer instrumentation (openzipkin…
ecd3cb7 
…#236)
@rcoedo rcoedo mentioned this issue Jul 10, 2018
Merged
rcoedo pushed a commit to rcoedo/zipkin-js that referenced this issue Jul 10, 2018
Allow host to be overridden in httpServer instrumentation (openzipkin…
c2ea28e 
…#236)
rcoedo pushed a commit to rcoedo/zipkin-js that referenced this issue Jul 10, 2018
Allow host to be overridden in httpServer instrumentation (openzipkin…
d727d9b 
…#236)
rcoedo pushed a commit to rcoedo/zipkin-js that referenced this issue Jul 10, 2018
Allow host to be overridden in httpServer instrumentation (openzipkin…
b6d7ee6 
…#236)
jcchavezs added a commit that referenced this issue Jul 10, 2018
@jcchavezs
Merge pull request #237 from rcoedo/master
6f77a2a 
Allow host to be overridden in httpServer instrumentation (#236)
@jcchavezs
Copy link
Contributor

Closed by #237

@jcchavezs jcchavezs mentioned this issue Aug 11, 2018
Open
This was referenced Jun 6, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcchavezs @rcoedo