Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds zipkin-instrumentation-redis support #47

Closed
wants to merge 2 commits into from

Conversation

securingsincity
Copy link
Contributor

Closes #27

  • Note I didn't include all of the redis commands, but a base set to get started similar to the memcached module

@codefromthecrypt
Copy link
Member

food for thought. in finagle, redis is a simple RPC trace with the span.name being the redis command.

so it would be something like:

span.name="append"
annotations="cs","cr" and possibly a "Client Receive Error" pattern

https://github.com/twitter/finagle/blob/develop/finagle-redis/src/main/scala/com/twitter/finagle/redis/filter/RedisTracingFilter.scala
https://github.com/twitter/finagle/blob/develop/finagle-redis/src/main/scala/com/twitter/finagle/redis/protocol/Command.scala

@securingsincity
Copy link
Contributor Author

@adriancole that's super helpful I'll take a look thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants