Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: adds test to verify context during concurrent request #498

Merged
merged 1 commit into from May 14, 2020

Conversation

kurtharriger
Copy link

@kurtharriger kurtharriger commented May 2, 2020

Adds a test for concurrent request that ensures that content is correctly preserved over promises when using cls-hooked.

If you change

ctxImpl = new CLSContext('zipkin', true); 

to

ctxImpl = new CLSContext('zipkin', false);

the test will fail.

@kurtharriger kurtharriger changed the title tests: adds test to verify context during concurrent request #476 tests: adds test to verify context during concurrent request May 2, 2020
@kurtharriger kurtharriger changed the title #476 tests: adds test to verify context during concurrent request tests: adds test to verify context during concurrent request May 2, 2020
@jcchavezs
Copy link
Contributor

Thanks a lot @kurtharriger, could you please also add the failing case?

@jcchavezs jcchavezs merged commit 57c17e1 into openzipkin:async_await May 14, 2020
@jcchavezs
Copy link
Contributor

I'll add the test case myself. Thanks a lot @kurtharriger!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants