Skip to content

Commit

Permalink
chore: minor improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
jcchavezs committed Sep 13, 2021
1 parent a9fa40a commit f18d174
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Zipkin/Endpoint.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public static function createFromGlobals(): self

public static function createAsEmpty(): self
{
return new self('unknown', null, null, null);
return new self(self::DEFAULT_SERVICE_NAME, null, null, null);
}

public function getServiceName(): string
Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Reporters/HttpTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class HttpTest extends TestCase
{
use ProphecyTrait;

public const PAYLOAD = '[{"id":"%s","traceId":"%s",'
private const PAYLOAD = '[{"id":"%s","traceId":"%s",'
. '"timestamp":%d,"name":"test","localEndpoint":{"serviceName":"unknown"}}]';

public function testHttpReporterSuccess()
Expand Down

0 comments on commit f18d174

Please sign in to comment.