Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct inaccurate expression #135

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix: Correct inaccurate expression #135

merged 1 commit into from Apr 8, 2020

Conversation

pauci
Copy link
Contributor

@pauci pauci commented Apr 8, 2020

Fixes #134

@jcchavezs
Copy link
Contributor

Thank you!

@jcchavezs jcchavezs merged commit a91e573 into openzipkin:master Apr 8, 2020
@jcchavezs
Copy link
Contributor

Are you using 1.x? I can do a new release with this change.

@pauci
Copy link
Contributor Author

pauci commented Apr 8, 2020

I'm using 1.3.4, but I made custom sampler already, so I'm ok.

@jcchavezs
Copy link
Contributor

jcchavezs commented Apr 8, 2020 via email

jcchavezs pushed a commit that referenced this pull request Apr 19, 2020
@pauci @jcchavezs
fix: Correct inaccurate expression (#135)
3a3ae88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccuracy in PercentageSampler
2 participants
@pauci @jcchavezs