upgrade to Kafka 2.7 and off kafka-junit #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adriancole kafka tests are working now. |
|
@jeqo could you take this one over? |
This moves to testcontainers, but has a glitch maybe @jeqo can help solve. Once done, we also need to sort out benchmarks as that also uses kafka-junit.
jeqo
changed the title
jcchavezs
reviewed
Oct 31, 2021
| } | ||
| waitStrategy = Wait.forHealthcheck(); | ||
| // 19092 is for connections from the Docker host and needs to be used as a fixed port. | ||
| // TODO: someone who knows Kafka well, make ^^ comment better! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to testcontainers, but has a glitch maybe @jeqo can help solve.
Once done, we also need to sort out benchmarks as that also uses kafka-junit.