Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not filter by “Duration (μs)> =” in the UI #1349

Closed
longinhit opened this issue Oct 24, 2016 · 9 comments
Closed

Can not filter by “Duration (μs)> =” in the UI #1349

longinhit opened this issue Oct 24, 2016 · 9 comments
Labels

Comments

@longinhit
Copy link

No description provided.

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Oct 25, 2016 via email

@michaelsembwever
Copy link
Member

@longinhit it's supported in the cassandra3 storage, if you're able to upgrade.

@dangets
Copy link
Contributor

dangets commented Nov 21, 2016

Is this the same issue with the Elasticsearch backend? Results that shouldn't be are getting filtered out.

zipkin 1
zipkin 2

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 22, 2016 via email

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 22, 2016 via email

@dangets
Copy link
Contributor

dangets commented Nov 22, 2016

We are using brave v3.15.1. We were previously using v3.9.1 until a few weeks ago and that is around when we started seeing the problem (upgraded brave and zipkin-server jar).

We do use a custom jmeter setup to run automated tests and we generate a traceId before sending the initial request so that we can log traceIds alongside request logs. Using the raw endpoint I am seeing sr and ss on the top-level span but it looks like the duration field is missing from that span.

Again, this was working previously - is this something that has changed during the deprecation of the SpanCollector classes? I can try switching to the Reporter classes to see if that fixes it.

@dangets
Copy link
Contributor

dangets commented Nov 22, 2016

I verified that when I hit an endpoint using curl and specifying a traceId in the headers the duration does not show up. Without the headers it does.

And we found this comment that says a timestamp/duration won't be kept if a traceId is sent - perhaps the cause? https://github.com/openzipkin/brave/blob/181a2f438e5142510cb72eefc723839bc525fe4d/brave-core/src/main/java/com/github/kristofa/brave/ServerRequestInterceptor.java#L50

Does a backfilling as mentioned in the comment ever happen?

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Nov 23, 2016 via email

@codefromthecrypt
Copy link
Member

This issue was moved to openzipkin/brave#277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants