Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move collector service instantiation logic to zipkin-collector-service #157

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 23 additions & 11 deletions project/Project.scala
Expand Up @@ -28,7 +28,7 @@ object Zipkin extends Build {
Project( Project(
id = "zipkin", id = "zipkin",
base = file(".") base = file(".")
) aggregate(hadoop, hadoopjobrunner, test, thrift, server, common, scrooge, collectorScribe, web, cassandra, collectorCore) ) aggregate(hadoop, hadoopjobrunner, test, thrift, server, common, scrooge, collectorScribe, web, cassandra, collectorCore, collectorService)




lazy val hadoop = Project( lazy val hadoop = Project(
Expand Down Expand Up @@ -121,7 +121,7 @@ object Zipkin extends Build {
name := "zipkin-test", name := "zipkin-test",
version := "0.3.0-SNAPSHOT", version := "0.3.0-SNAPSHOT",
libraryDependencies ++= testDependencies libraryDependencies ++= testDependencies
) dependsOn(server, collectorScribe) ) dependsOn(server, collectorService)


lazy val thrift = lazy val thrift =
Project( Project(
Expand Down Expand Up @@ -283,17 +283,29 @@ object Zipkin extends Build {
TravisCiRepos.newSettings TravisCiRepos.newSettings
).settings( ).settings(
version := "0.3.0-SNAPSHOT", version := "0.3.0-SNAPSHOT",
libraryDependencies ++= testDependencies, libraryDependencies ++= testDependencies
).dependsOn(collectorCore, scrooge)


PackageDist.packageDistZipName := "zipkin-scribe.zip", lazy val collectorService = Project(
BuildProperties.buildPropertiesPackage := "com.twitter.zipkin", id = "zipkin-collector-service",
base = file("zipkin-collector-service"),
settings = Project.defaultSettings ++
StandardProject.newSettings ++
SubversionPublisher.newSettings ++
TravisCiRepos.newSettings
).settings(
version := "0.3.0-SNAPSHOT",
libraryDependencies ++= testDependencies,


/* Add configs to resource path for ConfigSpec */ PackageDist.packageDistZipName := "zipkin-collector-service.zip",
unmanagedResourceDirectories in Test <<= baseDirectory { BuildProperties.buildPropertiesPackage := "com.twitter.zipkin",
base =>
(base / "config" +++ base / "src" / "test" / "resources").get /* Add configs to resource path for ConfigSpec */
} unmanagedResourceDirectories in Test <<= baseDirectory {
).dependsOn(collectorCore, scrooge, cassandra) base =>
(base / "config" +++ base / "src" / "test" / "resources").get
}
).dependsOn(collectorCore, collectorScribe, cassandra)


lazy val web = lazy val web =
Project( Project(
Expand Down