Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation's ToString provides all extra data #220

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Annotation's ToString provides all extra data #220

merged 2 commits into from
Sep 13, 2018

Conversation

sphinxy
Copy link
Contributor

@sphinxy sphinxy commented Sep 13, 2018

For example, while using ConsoleTracer for debugging, we see only
"TagAnnotation: http.host [System.String]"
without info about host, now it becomes
"TagAnnotation: http.host [127.0.0.1 System.String]"

Same is done for some other Annotations with taking into account previously used format.

Btw, i don't see a point for showing [System.String] and propose to use the following format:
"TagAnnotation: http.host:127.0.0.1" or "TagAnnotation: http.host=127.0.0.1"

@fedj
Copy link
Collaborator

fedj commented Sep 13, 2018

Hi @sphinxy,

This adds some context, which is really great !
The value type was initially put because the tracer was supposed to be able to send any type of value type (bool, int, strings, ...) but the UI didn't manage them very well, forcing users to use only string. In the future version, the value will only be of string type. I would say that we can remove the type in the toString as it doesn't bring value anymore.

@sphinxy
Copy link
Contributor Author

sphinxy commented Sep 13, 2018

Type info removed, now it's
TagAnnotation: http.host:127.0.0.1

@fedj fedj merged commit 523001b into openzipkin:master Sep 13, 2018
@fedj
Copy link
Collaborator

fedj commented Sep 13, 2018

Thanks a lot @sphinxy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants