New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if current trace is null in ClientTrace.Error #227

Merged

fedj merged 1 commit into openzipkin:master from akurin:fix-null-reference

Jan 21, 2019

akurin commented Jan 21, 2019

TracingHandler throws NullReferenceException when current trace is null, as in the example below.

static async Task Main(string[] args)
{
    using (var client = new HttpClient(new TracingHandler("service-name")))
    {
        await client.GetAsync("http://non-existent-host"); // throws NullReferenceException
    }
}


          Check if current trace is null in ClientTrace.Error

2d3b3b0

devinsba requested a review from fedj

January 21, 2019 20:45

fedj approved these changes

View reviewed changes

Collaborator

fedj left a comment

Thank you for the change @akurin

fedj merged commit e2f656e into openzipkin:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment