Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCC-582025] add producer and consumer duration #236

Conversation

bvillanueva-mdsol
Copy link
Contributor

@bvillanueva-mdsol bvillanueva-mdsol commented Mar 30, 2020

Problem: PRODUCER and CONSUMER spans don't have duration

Fix: Add missing duration if spans are of type PRODUCER and CONSUMER

Before fix:
image

{
    "traceId": "94e28dc9de676b4e",
    "id": "ae0f80cea8c7bbdc",
    "kind": "PRODUCER",
    "name": "send message",
    "timestamp": 1585558441828882,
    "localEndpoint": {
        "serviceName": "sample-producer-app",
        "ipv4": "10.152.25.139"
    }
},
{
    "traceId": "94e28dc9de676b4e",
    "parentId": "ae0f80cea8c7bbdc",
    "id": "f2b9e8d7ea1be767",
    "kind": "CONSUMER",
    "name": "process message",
    "timestamp": 1585558443351661,
    "localEndpoint": {
        "serviceName": "sample-consumer-app",
        "ipv4": "10.152.25.139"
    },
    "tags": {
        "sample-tag": "xxxxxxx"
    }
}

After fix:
image

{
    "traceId": "61559458b511fabc",
    "id": "2a74a0d0317cd641",
    "kind": "PRODUCER",
    "name": "send message",
    "timestamp": 1585558223243729,
    "duration": 505172,
    "localEndpoint": {
        "serviceName": "sample-producer-app",
        "ipv4": "10.152.25.139"
    }
},
{
    "traceId": "61559458b511fabc",
    "parentId": "2a74a0d0317cd641",
    "id": "a40567c56200025a",
    "kind": "CONSUMER",
    "name": "process message",
    "timestamp": 1585558224756748,
    "duration": 2858012,
    "localEndpoint": {
        "serviceName": "sample-consumer-app",
        "ipv4": "10.152.25.139"
    },
    "tags": {
        "sample-tag": "xxxxxxx"
    }
}

Please review and merge. @adriancole @jcarres-mdsol

@bvillanueva-mdsol bvillanueva-mdsol marked this pull request as ready for review March 30, 2020 09:02
@codefromthecrypt
Copy link
Member

thanks for the fix! got time for a unit test?

@bvillanueva-mdsol
Copy link
Contributor Author

@adriancole Updated with unit test :) Thanks!

@bvillanueva-mdsol
Copy link
Contributor Author

@bvillanueva-mdsol bvillanueva-mdsol changed the title add producer and consumer duration [MCC-582025 Actions] add producer and consumer duration Mar 31, 2020
@bvillanueva-mdsol bvillanueva-mdsol changed the title [MCC-582025 Actions] add producer and consumer duration [MCC-582025] add producer and consumer duration Mar 31, 2020
@bvillanueva-mdsol
Copy link
Contributor Author

@adriancole @jcarres-mdsol Can we merge this? Thanks! :)

@codefromthecrypt
Copy link
Member

Thanks for the help on this!

still we need someone to help release it.

@codefromthecrypt codefromthecrypt merged commit bd21e85 into openzipkin:master Apr 2, 2020
@bvillanueva-mdsol bvillanueva-mdsol deleted the fix/add-duration-for-ms-mr-spans branch April 6, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants