Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds authenticator layer to the SDK for the client and management api #377

Merged
merged 1 commit into from
Apr 24, 2023
Merged

adds authenticator layer to the SDK for the client and management api #377

merged 1 commit into from
Apr 24, 2023

Conversation

andrewpmartinez
Copy link
Member

  • remove conf sub modules, renames config.New* to ziti.NewConfig* removes conflicts with app that have their own conf module
  • adds authenciation mechanisms for client/management APIs
  • uses new authentication mechanisms for all auth paths, patches old identity.ID configuration for backwards compat

@andrewpmartinez andrewpmartinez requested a review from a team as a code owner April 18, 2023 19:21
dovholuknf
dovholuknf reviewed Apr 19, 2023
View reviewed changes
ziti/identity.go Outdated Show resolved Hide resolved
dovholuknf
dovholuknf reviewed Apr 19, 2023
View reviewed changes
ziti/identity.go Outdated Show resolved Hide resolved
dovholuknf
dovholuknf reviewed Apr 19, 2023
View reviewed changes
management/authenticators.go Outdated
@@ -0,0 +1,329 @@
package ziti
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these functions will be some of the first ones people explore, i'd really appreciate godoc on them once we agree on the api

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure sure.

dovholuknf
dovholuknf requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@dovholuknf dovholuknf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to pause my review and ask for changes i've already commented on. Maybe we can talk in person? I don't think we should merge this as is.

@andrewpmartinez
adds authenticator layer to the SDK for the client and management api
341b7d0 
- remove conf sub modules, renames config.New* to ziti.NewConfig* removes
  conflicts with app that have their own conf module
- adds authenciation mechanisms for client/management APIs
- uses new authentication mechanisms for all auth paths, patches old
  identity.ID configuration for backwards compat
- remove go.work/sum file, replaced with replace stanzas in example
  go.mod files
- adds doc
- de-dupes IdentityProvider interface
- renames ApiAuthenticator to Authenticator
- moves client API utilities to client_api
- moves management API utilities to management_api
- adds edge_apis packaged
- single authenticator implementation
- makes CaPool on client the default unless set on Credentials
@andrewpmartinez andrewpmartinez merged commit 3eb3bd7 into main Apr 24, 2023
@andrewpmartinez andrewpmartinez deleted the fix.fetch.cert.nil.pointer branch April 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plorenz plorenz plorenz left review comments

@dovholuknf dovholuknf dovholuknf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewpmartinez @plorenz @dovholuknf