fixes updb enrollment, underlying error types changed #383
Conversation
Instead of checking for specific error types, try blindly to ensure success.
There was a problem hiding this comment.
Do we have any doc that states explicitly you will now need to include the entire chain in the cas store if you're using a third party 'verifiable' CA? Before, it'd use the OS trust store and now it exclusively fetches the certificates every time, which is fine, but we need to make sure people know that they need to add the full chain of trust for this to work now, assuming I'm understanding this change correcctly
There was a problem hiding this comment.
This only changes the error detection. Prior to this, the code checked for specific error types, which have changed with golang upgrades. This change removes the type assertions and looks for any error.
Other than that, I do not believe any behavior has changed.
Instead of checking for specific error types, try blindly to ensure success.