Don't send close in response to close. Fixes #443 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camotts
approved these changes
Oct 31, 2023
dovholuknf
reviewed
Oct 31, 2023
| @@ -146,10 +150,7 @@ func (listener *edgeListener) Close() error { | |||
| edgeChan.hosting.Delete(listener.token) | |||
|
|
|||
| defer func() { | |||
| if err := edgeChan.Close(); err != nil { | |||
| logger.WithError(err).Error("unable to close conn") | |||
There was a problem hiding this comment.
this isn't possible to fail? i don't see why not log it. was it super chatty?
There was a problem hiding this comment.
Close() returns an error to conform to the io.Closer interface. However close(bool) doesn't since it doesn't need to conform to the interface, (and Close() always returned nil because it just called close()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.