Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix IO re-start #192

Merged
merged 2 commits into from Dec 2, 2023
Merged

fix IO re-start #192

merged 2 commits into from Dec 2, 2023

Conversation

ekoby
Copy link
Member

@ekoby ekoby commented Dec 2, 2023

  • start_read: set read_cb before configuring IO
  • try_write: prevent going before previous writes
  • make sure to watch for UV_WRITABLE after queuing write request

@ekoby
fix IO re-start
db3cf5b 
- start_read: set read_cb before configuring IO
- try_write: prevent going before previous writes
- make sure to watch for UV_WRITABLE after queuing write request
@ekoby ekoby requested a review from a team as a code owner December 2, 2023 00:32
scareything
scareything approved these changes Dec 2, 2023
View reviewed changes
src/tlsuv.c
@@ -262,7 +289,7 @@ static void process_outbound(tlsuv_stream_t *clt) {
}

req = TAILQ_FIRST(&clt->queue);
ret = tlsuv_stream_try_write(clt, &req->buf);
ret = write_req(clt, &req->buf);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no concern for jumping the line here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we're processing the head of the line

@ekoby ekoby merged commit 1b30ab5 into main Dec 2, 2023
11 checks passed
@ekoby ekoby deleted the fix-io-restart branch December 2, 2023 01:14
@ekoby ekoby added the bug Something isn't working label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scareything scareything scareything approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekoby @scareything