fix mkdir command that enables clobbering tmp identity in container #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scareything
reviewed
Feb 20, 2024
| @@ -61,7 +61,8 @@ fi | |||
| # if identity env var is defined then do not look for mounted identities | |||
| if [[ -n "${ZITI_IDENTITY_JSON:-}" ]]; then | |||
| IDENTITIES_DIR="/tmp/openziti" | |||
| mkdir -m0700 "${IDENTITIES_DIR}" | |||
| # shellcheck disable=SC2174 | |||
| mkdir -pm0700 "${IDENTITIES_DIR}" | |||
There was a problem hiding this comment.
What's this fixing? Is the /tmp directory actually missing sometimes? If so, how does that happen? We should prevent that if possible because /tmp is an important directory.
There was a problem hiding this comment.
The problem is that /tmp/openziti already exists if a container is resumed, so mkdir always fails in that case with an error like "file exists."
The fix is to tolerate the existing directory because the goal of this hunk is to clobber /tmp/openizti/${ZITI_IDENTITY_BASENAME}.json with the value of $ZITI_IDENTITY_JSON.
scareything
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.