Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link management race conditions found by chaos testing #1709

Closed
plorenz opened this issue Jan 25, 2024 · 0 comments · Fixed by #1716
Closed

Fix link management race conditions found by chaos testing #1709

plorenz opened this issue Jan 25, 2024 · 0 comments · Fixed by #1716
Assignees
Labels
bug Something isn't working fabric Issue is related to fabric level functionality

Comments

@plorenz
Copy link
Member

plorenz commented Jan 25, 2024

  1. Fix issue where messages from router can be processed after router has disconnected or reconnected
  2. Fix issue where async processing of router link notification can happen after async notification of link fault by making router link processing synchronous
  3. Ensure we're comparing routers by id, in case instances have changed
  4. Keep trying to send faults to controllers until they've been disconnected for a while. This avoids issues with controllers missing faults if they're only briefly disconnected
  5. Ensure only one dial for a link can happen at a given time, since link status can changed due to incoming links
  6. Cleanup partial links if first part of splink link fails bind
  7. Fix issue with missed link notification when notification of replaced link clears flag for notification of new link
  8. Fix router cache set on error
@plorenz plorenz added bug Something isn't working fabric Issue is related to fabric level functionality labels Jan 25, 2024
@plorenz plorenz self-assigned this Jan 25, 2024
@plorenz plorenz changed the title Fix additional link management race conditions Fix link management race conditions found by chaos testing Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric Issue is related to fabric level functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant