controller crashes generating create circuit responses

[plorenz]

Crashes occurred first in protobuf code, then in manual marshaling code, both times while doing slice appends. Seems like to be a bug in the go runtime.

Example:

unexpected fault address 0x7f741367419c
fatal error: fault
[signal SIGBUS: bus error code=0x2 addr=0x7f741367419c pc=0x14d0841]

goroutine 2049524 [running]:
runtime.throw({0x3955ef5?, 0x7f749eeea878?})
        /home/plorenz/go/go1.21.6/src/runtime/panic.go:1077 +0x5c fp=0xc003273510 sp=0xc0032734e0 pc=0x149745c
runtime.sigpanic()
        /home/plorenz/go/go1.21.6/src/runtime/signal_unix.go:858 +0x116 fp=0xc003273570 sp=0xc003273510 pc=0x14af5f6
runtime.memmove()
        /home/plorenz/go/go1.21.6/src/runtime/memmove_amd64.s:184 +0x141 fp=0xc003273578 sp=0xc003273570 pc=0x14d0841
github.com/openziti/channel/v2.EncodeU32ToBytesMap(...)
        /home/plorenz/work/nf/channel/message.go:809
github.com/openziti/channel/v2.Headers.PutU32ToBytesMapHeader(...)
        /home/plorenz/work/nf/channel/message.go:288
github.com/openziti/channel/v2.(*MessageHeader).PutU32ToBytesMapHeader(0x386ab40?, 0xee8b10?, 0xc0049e73b0)
        /home/plorenz/work/nf/channel/message.go:173 +0x23f fp=0xc003273690 sp=0xc003273578 pc=0x19c9bbf
github.com/openziti/ziti/common/ctrl_msg.(*CreateCircuitResponse).ToMessage(0xc003273700)
        /home/plorenz/work/nf/ziti/common/ctrl_msg/messages.go:153 +0x185 fp=0xc0032736f8 sp=0xc003273690 pc=0x20c0ca5
github.com/openziti/ziti/controller/handler_edge_ctrl.(*createCircuitHandler).CreateCircuitV2Response(...)
        /home/plorenz/work/nf/ziti/controller/handler_edge_ctrl/create_circuit.go:119
github.com/openziti/ziti/controller/handler_edge_ctrl.(*createCircuitHandler).CreateCircuitV2Response-fm(0xc00272f5e0?, 0xc0032738a8?)
        <autogenerated>:1 +0x68 fp=0xc003273740 sp=0xc0032736f8 pc=0x3018c08
github.com/openziti/ziti/controller/handler_edge_ctrl.(*createCircuitHandler).CreateCircuit(0xc003be3740, 0xc00453a540, 0xc003273e28)
        /home/plorenz/work/nf/ziti/controller/handler_edge_ctrl/create_circuit.go:139 +0x2e7 fp=0xc003273db8 sp=0xc003273740 pc=0x2ff7fe7
github.com/openziti/ziti/controller/handler_edge_ctrl.(*createCircuitHandler).HandleReceiveCreateCircuitV2(0xc003be3740, 0xc004a343f0, {0x40c3900, 0xc00298b800})
        /home/plorenz/work/nf/ziti/controller/handler_edge_ctrl/create_circuit.go:108 +0x27b fp=0xc003273f88 sp=0xc003273db8 pc=0x2ff7c1b
github.com/openziti/ziti/controller/handler_edge_ctrl.(*createCircuitHandler).HandleReceiveCreateCircuitV2-fm(0x8ac39169ecd28439?, {0x40c3900?, 0xc00298b800?})
        <autogenerated>:1 +0x36 fp=0xc003273fb8 sp=0xc003273f88 pc=0x3018ad6
github.com/openziti/channel/v2.(*AsyncFunctionReceiveAdapter).HandleReceive.func1()
        /home/plorenz/work/nf/channel/handler.go:112 +0x2f fp=0xc003273fe0 sp=0xc003273fb8 pc=0x19c364f
runtime.goexit()
        /home/plorenz/go/go1.21.6/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc003273fe8 sp=0xc003273fe0 pc=0x14cf8e1
created by github.com/openziti/channel/v2.(*AsyncFunctionReceiveAdapter).HandleReceive in goroutine 330
        /home/plorenz/work/nf/channel/handler.go:112 +0xa7