Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller can try to send unroute to router which has since disconnected, causing panic #1854

Closed
plorenz opened this issue Mar 21, 2024 · 0 comments
Closed

Controller can try to send unroute to router which has since disconnected, causing panic #1854

plorenz opened this issue Mar 21, 2024 · 0 comments
Assignees
@plorenz
Labels
bug Something isn't working controller Issue related to the controller fabric Issue is related to fabric level functionality panic describes a code panic

Comments

@plorenz
Copy link
Member

plorenz commented Mar 21, 2024

Unroute code in CreateCircuit is using GetRouter instead of GetConnectedRouter, which can return a disconnected router with no control channel set.
@plorenz plorenz added bug Something isn't working controller Issue related to the controller fabric Issue is related to fabric level functionality panic describes a code panic labels Mar 21, 2024
@plorenz plorenz self-assigned this Mar 21, 2024
plorenz added a commit that referenced this issue Mar 21, 2024
@plorenz
Merge pull request #1855 from openziti/fix-unroute-panic
58b8048 
Fix panic if router is disconnected in unroute. Fixes #1854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plorenz plorenz

Labels
bug Something isn't working controller Issue related to the controller fabric Issue is related to fabric level functionality panic describes a code panic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plorenz