Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker tproxy router example #1785

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

qrkourier
Copy link
Member

No description provided.

@qrkourier qrkourier force-pushed the docker-router-example branch 2 times, most recently from a1bd3ca to 2bcbb70 Compare March 1, 2024 22:54
@qrkourier qrkourier linked an issue Mar 1, 2024 that may be closed by this pull request
Copy link
Member Author

@qrkourier qrkourier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -40,8 +40,8 @@ link:
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}#{{ end }} - binding: tunnel
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}#{{ end }} options:
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}# mode: host #tproxy|host{{ else }} mode: {{ .Router.TunnelerMode }} #tproxy|host{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://{{ .Router.Edge.AdvertisedHost }}:53{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} lanIf: {{ .Router.Edge.LanInterface }}{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://127.0.0.1:53{{ end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be a locally-bound IP address or 0.0.0.0 (all IPv4, IPv6 interfaces)

@@ -38,3 +38,7 @@
- get: /zdew/
raw: /openziti/desktop-edge-win/main/release-streams/
file: latest.json

- get: /dist/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplify the tproxy example by providing a short getter for the latest ziti-router compose file, and anything else in /dist/.

@@ -40,8 +40,8 @@ link:
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}#{{ end }} - binding: tunnel
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}#{{ end }} options:
{{ if or .Router.IsFabric (eq .Router.TunnelerMode "none") }}# mode: host #tproxy|host{{ else }} mode: {{ .Router.TunnelerMode }} #tproxy|host{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://{{ .Router.Edge.AdvertisedHost }}:53{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} lanIf: {{ .Router.Edge.LanInterface }}{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://0.0.0.0:53{{ end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be a local IP or 0.0.0.0

{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://{{ .Router.Edge.AdvertisedHost }}:53{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} lanIf: {{ .Router.Edge.LanInterface }}{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") }} resolver: udp://0.0.0.0:53{{ end }}
{{ if and (not .Router.IsFabric) (eq .Router.TunnelerMode "tproxy") (.Router.Edge.LanInterface) }} lanIf: {{ .Router.Edge.LanInterface }}{{ end }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty value is invalid router config, so only create the property if defined (solves #1780 )

@qrkourier qrkourier marked this pull request as ready for review March 1, 2024 22:58
@qrkourier qrkourier requested review from a team as code owners March 1, 2024 22:58
@qrkourier qrkourier added the quickstartrelease Release a quickstart container image and update the quickstart-latest Git tag used by /quick/ URLs label Mar 4, 2024
@qrkourier qrkourier changed the base branch from release-next to ziti-edge-service-helper March 4, 2024 20:07
@qrkourier qrkourier changed the base branch from ziti-edge-service-helper to release-next March 6, 2024 13:17
@qrkourier qrkourier marked this pull request as draft March 6, 2024 13:28
@qrkourier qrkourier changed the base branch from release-next to linux-package-controller March 8, 2024 17:30
@qrkourier qrkourier changed the base branch from linux-package-controller to linux-package-router March 8, 2024 19:46
@qrkourier qrkourier marked this pull request as ready for review March 8, 2024 19:47
@qrkourier qrkourier merged commit 7b4b84a into linux-package-router Mar 8, 2024
13 of 15 checks passed
@qrkourier qrkourier deleted the docker-router-example branch March 8, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quickstartrelease Release a quickstart container image and update the quickstart-latest Git tag used by /quick/ URLs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create config router edge - generates invalid config
1 participant