Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salted Argon2 Passwords #156

Closed
michaelquigley opened this issue Jan 13, 2023 · 1 comment
Closed

Salted Argon2 Passwords #156

michaelquigley opened this issue Jan 13, 2023 · 1 comment
Assignees
@michaelquigley
Labels
enhancement Enhancement of an existing feature
Milestone
v0.3

Comments

@michaelquigley
Copy link
Collaborator

Improve the password storage by incorporating a salt, and use the argon2 hashing function.

This will break existing users ability to log in. Existing users will need to go through the forgot password (#65) workflow to re-establish a working password after this change.

Thanks to @andrewpmartinez for the guidance.
@michaelquigley michaelquigley self-assigned this Jan 13, 2023
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jan 13, 2023
@michaelquigley michaelquigley added this to the v0.3 milestone Jan 13, 2023
@michaelquigley
Copy link
Collaborator Author

Existing example from the Ziti Edge:

https://github.com/openziti/edge/blob/main/crypto/hash.go

michaelquigley added a commit that referenced this issue Jan 23, 2023
@michaelquigley
salted password migrations (#156)
45d83d1
michaelquigley added a commit that referenced this issue Jan 23, 2023
@michaelquigley
implement the new password hashing approach (#156)
b32ee63
@michaelquigley michaelquigley mentioned this issue Jan 23, 2023
Merged
michaelquigley added a commit that referenced this issue Jan 23, 2023
@michaelquigley
fix sqlite migration (#156)
789532f
michaelquigley added a commit that referenced this issue Jan 23, 2023
@michaelquigley
Merge pull request #177 from openziti/passwords
1265de3 
Password Salting and Improved Hashing (#156)
michaelquigley added a commit that referenced this issue Jan 23, 2023
@michaelquigley
more emphasis (#156)
c34e004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelquigley michaelquigley

Labels
enhancement Enhancement of an existing feature
Projects
zrok Development Roadmap
Status: Done
Milestone
v0.3
Development

No branches or pull requests
1 participant
@michaelquigley