Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'zrok reserve' Not Properly Recording Reserved Metadata #427

Closed
michaelquigley opened this issue Oct 25, 2023 · 0 comments
Closed

'zrok reserve' Not Properly Recording Reserved Metadata #427

michaelquigley opened this issue Oct 25, 2023 · 0 comments
Assignees
@michaelquigley
Labels
defect Something isn't working
Milestone
v0.4

Comments

@michaelquigley
Copy link
Collaborator

The zrok reserve command is not properly recording the reserved flag. This happened when the CLI moved to sdk.CreateShare, which did not expose the flag for reserved shares. This prevented zrok release from properly releasing reserved shares.
@michaelquigley michaelquigley self-assigned this Oct 25, 2023
@michaelquigley michaelquigley added the defect Something isn't working label Oct 25, 2023
@michaelquigley michaelquigley added this to the v0.4 milestone Oct 25, 2023
@michaelquigley michaelquigley mentioned this issue Oct 25, 2023
Closed
michaelquigley added a commit that referenced this issue Oct 25, 2023
@michaelquigley
sdk fixes to re-instate reserved share metadata (#427)
7796421
michaelquigley added a commit that referenced this issue Oct 25, 2023
@michaelquigley
Merge pull request #428 from openziti/reserved_metadata_fix
94d17ab 
sdk fixes to re-instate reserved share metadata (#427)
michaelquigley added a commit that referenced this issue Oct 25, 2023
@michaelquigley
changelog (#427)
64b9c68
camotts pushed a commit that referenced this issue Nov 16, 2023
@michaelquigley @camotts
sdk fixes to re-instate reserved share metadata (#427)
1a7d2a2
camotts pushed a commit that referenced this issue Nov 16, 2023
@michaelquigley @camotts
changelog (#427)
daf7078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelquigley michaelquigley

Labels
defect Something isn't working
Projects
zrok Development Roadmap
Status: Done
Milestone
v0.4
Development

No branches or pull requests
1 participant
@michaelquigley