No more Carrier #590
Merged
No more Carrier #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the streamlined Spanner, we don't need many dependencies anymore. However, we were getting Adz and Carrier transitively through Spanner; we need to explicitly pull those in now.
Cog is the only consumer of Carrier now, so that means Carrier can go away. We need to tweak the configuration path for the Carrier bits now, though, since there is no Carrier application anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cog is the only consumer of Carrier now, so we can pull that code into Cog.
Ideally, all this would go into
lib/coginstead oflib/carrier, but doing that (with the attendant renames) would cause issues with theCredentialStoreon existing installations. Really, the only reason that theCredentialStoreis used anymore is so the embedded bundle / commands can know what their "relay ID" is. Fixing that up is a task left for another PR, though, but then what was Carrier will only be theConnectionmodule.