Fix emqttd mgmt;Refine process tree structure #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Cog.BusDriver` now traps exits if it successfully starts `emqttd`. This allows Cog to keep the message bus state in sync with Cog's overall state. If Cog is up, the message bus is up. If Cog is down, the message bus is down. - Removed the `mnesia` data file deletion logic from `Cog.BusDriver. Wound up causing more problems than it solved. We can tell users to delete the data dir in the release notes. - Moved all of Cog core, modulo `Cog.Repo` and `Cog.BusDriver`, to a separate supervisor named `Cog.CoreSup` with a restart strategy of one-for-one. The top level supervisor is now responsible for `Cog.Repo`, `Cog.BusDriver`, and `Cog.CoreSup` and uses the one-for-all restart strategy. This should stabilize Cog as all processes will be restarted if the database or message bus goes down. Fixes #897
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cog.BusDrivernow traps exits if it successfully startsemqttd. This allows Cog to keep the message bus state in sync withCog's overall state. If Cog is up, the message bus is up. If Cog is
down, the message bus is down.
mnesiadata file deletion logic from`Cog.BusDriver. Wound up causing more problems than it solved. We can
tell users to delete the data dir in the release notes.
Cog.RepoandCog.BusDriver, to aseparate supervisor named
Cog.CoreSupwith a restart strategy ofone-for-one. The top level supervisor is now responsible for
Cog.Repo,Cog.BusDriver, andCog.CoreSupand uses theone-for-all restart strategy. This should stabilize Cog as all
processes will be restarted if the database or message bus goes down.
Fixes #897